Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Prevents FloorOcclusion from breaking rendering #136

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25960: Prevents FloorOcclusion from breaking rendering from space-wizards space-wizards/space-station-14

717da4a8f3b6d68cb17d6bf75c84eae6ce46e1b5

PR opened by DoutorWhite at 2024-03-10 08:16:46 UTC
PR merged by web-flow at 2024-03-10 17:07:24 UTC


PR changed 1 files with 6 additions and 1 deletions.

The PR had the following labels:


Original Body

About the PR

This PR adds a condition so that FloorOcclusionSystem does not overwrite existing PostShaders.

Why / Balance

Because if a Mutable PostShader already exists, the FloorOcclusionSystem will simply replace it with its own, which is Immutable, which creates conflict with other systems and breaks the game's rendering and UI, to the point that all clients are immediately left with a black screen and the FPS drops to 0, eventually resulting in a crash. There is an in-game situation where this bug is replicable and I will not address it publicly in this PR because it is potentially game breaking, if you want you can chat with me via DM on discord (my name is the same).

Technical details

Adds an extra condition so that the FloorOcclusionSystem does not replace the PostShader of other systems. Honestly this is a workaround, this system should be redone in the engine, but I don't have the knowledge to do so.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

The FloorOcclusionSystem should no longer work if there is already another PostShader in sprite.

Changelog

🆑

  • fix: Prevents rendering from crashing in certain scenarios

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 4, 2024 23:49
@VMSolidus VMSolidus enabled auto-merge (squash) May 5, 2024 00:41
@VMSolidus VMSolidus merged commit cb108dd into Simple-Station:master May 5, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants